New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ctrl+space freezes irssi on GLib >2.62 #1180
Labels
Milestone
Comments
Affects all Irssis on GLib > 2.62 |
ailin-nemui
changed the title
ctrl+space freezes irssi
ctrl+space freezes irssi on GLib >2.62
Apr 24, 2020
You can test this patch: ailin-nemui@glib-2-63 |
That sounds good and it works, add some more detail to the commit message and throw a PR? |
ailin-nemui
added a commit
to ailin-nemui/irssi
that referenced
this issue
Apr 28, 2020
A change in GLib 2.63 broke some assumptions in Irssi that the null-byte NUL / U+0000 is a valid Unicode character. This would occur when the user types Ctrl+Space. As a result, the input loop never manages to process the NUL-byte (and any other user input that follows, ever). This patch adds a manual check that properly advances the input loop if GLib returns -2 (incomplete character) despite the length being positive and a NUL is in first position. Fixes irssi#1180 https://gitlab.gnome.org/GNOME/glib/-/merge_requests/967 https://gitlab.gnome.org/GNOME/glib/-/issues/2093
I ran into this bug after updating Ubuntu and accidentally pressing |
bob-beck
pushed a commit
to openbsd/ports
that referenced
this issue
May 27, 2020
irssi/irssi#1180 Patch confirmed to fix irssi-1.2.2 with glib2-2.64.2 on snapshots; irssi-1.2.2 with glib2-2.62.2 on 6.7 seems not effected.
algitbot
pushed a commit
to alpinelinux/aports
that referenced
this issue
Jan 11, 2021
add patch from upstream: irssi/irssi#1180
algitbot
pushed a commit
to alpinelinux/aports
that referenced
this issue
Jan 11, 2021
add patch from upstream: irssi/irssi#1180
martinetd
added a commit
to martinetd/nixpkgs
that referenced
this issue
Mar 17, 2021
See irssi/irssi#1180 for rationale
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A change in GLib 2.63 broke some assumptions in Irssi that the null-byte NUL / U+0000 is a valid Unicode character. This would occur when the user types Ctrl+Space. As a result, the input loop never manages to process the NUL-byte (and any other user input that follows, ever).
This affects all versions of Irssi as soon as your system is updated to this GLib version.
GLib issued a statement that this needs to be changed in Irssi: https://gitlab.gnome.org/GNOME/glib/-/issues/2093
A patch for Irssi 1.2.2 is available at https://github.com/irssi/irssi/releases/download/1.2.2/glib-2-63.patch
original bug report follows
The text was updated successfully, but these errors were encountered: